[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9)

[WordPress Trac]

#41074: Create new Dashicons (4.9)
---------------------------+--------------------
 Reporter:  EmpireOfLight  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  4.9
Component:  Editor         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  ui
---------------------------+--------------------

Comment (by EmpireOfLight):

 Replying to [comment:16 netweb]:
 > Replying to [comment:15 EmpireOfLight]:
 > > Having trouble creating the patch / .diff ifle. Also, there's a .woff
 file in /wp-includes/fonts that we don't make with the new repository (see
 https://github.com/WordPress/dashicons/tree/master/icon-font) ; should
 this be removed or should we be building a .woff file?

 Hoping someone can answer this...

 >
 > Likewise, having trouble here also creating a patch file to upload here,
 most likely this will need to be performed diretly during commit for these
 binary files /shrug
 >
 > What I have done in [attachment:41074.diff] is:
 >
 > * Copy the `dashicons.css` file over the existing and manually tweak the
 formatting to match the coding standards.
 >
 > * I used SVN to rename `dashicons.woff` to `dashicons.woff2` and then
 copied over the new `dashicons.woff2` from [attachment:icon-font.zip].
 >
 I'm confused about what you did here...does this mean there's no longer a
 .woff file?

 > * `dashicons.eot` and dashicons.ttf` are also replaced with the new
 versions from [attachment:icon-font.zip].
 >
 > * `dashicons.svg` remains unchanged, should anything be done to this SVG
 file? There is no SVG in [attachment:icon-font.zip]
 >
 > * The remaining files in [attachment:icon-font.zip] I've not added to
 the `/wp-includes/fonts` folder, should they?
 I think you're referring to the .html files... dashicons.html is just for
 previewing the font, and I'm not sure what demo-template.html does, but
 they don't need to be included. Maybe the grunt build process should be
 updated to create a directory with just the font files, and have the
 html/css files go somewhere else.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform