[wp-trac] [WordPress Trac] #42184: Customizer theme install getting stuck on downloading

[WordPress Trac]

#42184: Customizer theme install getting stuck on downloading
--------------------------+-----------------------------
 Reporter:  helen         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Customize     |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 I've been getting into situations with the new theme browser/installer in
 the customizer where it gets stuck on the downloading spinner or the
 install button doesn't actually work at all - you can click it but nothing
 happens, and no errors in the console.

 I *think* this has to do with the fact that I'm also messing around with
 forcing the FTP credential prompt for other purposes and toggling that on
 and off in PHP without reloading the page. This itself may (probably) be
 an edge case that doesn't need addressing, but I think the error handling
 could be better and may come up in other situations.

 Steps to reproduce:

 1. Browse .org themes in the customizer.
 2. With forced FTP on (will add code for this in a followup comment),
 attempt to "install and preview" from the grid view.
 3. Observe that failure notice appears over the screenshot and button
 changes to `Installation failed` but remains primary and active
 4. Disable forcing FTP in PHP elsewhere; do not reload page.
 5. Button on the attempted theme is still clickable but does nothing, all
 other buttons will take you to the downloading spinner which never
 completes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42184>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform