[wp-trac] [WordPress Trac] #42113: Customize Menus: Copy updates
WordPress Trac
noreply at wordpress.org
Wed Oct 11 06:56:26 UTC 2017
#42113: Customize Menus: Copy updates
--------------------------+------------------------
Reporter: melchoyce | Owner: bpayton
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 4.9
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui
--------------------------+------------------------
Comment (by bpayton):
I pushed an update to put the menu widget note on a new line.
I took a look at the spacing of the location list items and confirmed the
issue only affects the new-menu section. The spacing of the checkboxes in
edit-menu sections looks just fine (though I did push a commit to add
padding between locations and the auto-add-top-level-pages control).
The strange thing is that the edit menu section relies on styles defined
in `nav-menus.css` and a rule for `.menu li`. The rule(s) apply because
we're manually adding the `menu` class to the content container when a
menu section is expanded. This is poor because we're relying on styles
defined for menu admin rather than for Customizer. To address the new-menu
spacing issue and to reduce the edit-menu reliance on `nav-menus.css`, I
added (and pushed) a rule that explicitly sets item spacing for the new-
and edit-menu sections.
@melchoyce, this is ready for another review.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42113#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list