[wp-trac] [WordPress Trac] #42111: Heads up! modal better responsive on narrow screens

[WordPress Trac]

#42111: Heads up! modal better responsive on narrow screens
-------------------------------------------------+-------------------------
 Reporter:  sami.keijonen                        |       Owner:  helen
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.9
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by helen):

 Hi @Mirucon - thanks for the patch. Could you possibly attach screenshots
 of what you see with your patch? I'm getting odd results where the modal
 is off the screen or not showing at all, and the toolbar at the top seems
 to be affected. Additionally, your patch affects other instances of
 `.notification-dialog` and associated - the post edit lock (when somebody
 else is already editing a post and you also head to the editor for that
 post) and FTP credentials ones come to mind. A solution may need to be
 specific to this modal since this isn't really a completely thought-out
 component, with enhancements noted for a later release.

 To test the FTP credentials modal, you'll want to use this code snippet in
 a plugin file and try doing something that involves installation or
 upgrade, like installing a theme or plugin.

 {{{
 <?php
 /**
  * Plugin Name: Force FTP
  * Description: Used to test FTP credentials screen.
  */

 add_filter( 'filesystem_method', function() {
         return 'ftpext';
 } );

 add_filter( 'fs_ftp_connection_types', function() {
         return [
                 'ftp'  => __( 'FTP' ),
                 'ftps' => __( 'FTPS (SSL)' ),
                 'ssh'  => __( 'SSH2' ),
         ];
 } );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42111#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform