[wp-trac] [WordPress Trac] #41894: Clear dirty flag on widgets admin screen when widget is deleted to prevent irrelevant “Are you sure?” prompt

WordPress Trac noreply at wordpress.org
Tue Oct 10 18:57:57 UTC 2017


#41894: Clear dirty flag on widgets admin screen when widget is deleted to prevent
irrelevant “Are you sure?” prompt
--------------------------+--------------------------
 Reporter:  westonruter   |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  high          |   Milestone:  4.9
Component:  Widgets       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+--------------------------
Changes (by felipeelia):

 * keywords:  needs-patch => has-patch


Comment:

 I uploaded a patch with the necessary handling for inactive widgets.

 The another place where you saw a removal happening, @westonruter, is the
 `stop` event of sorting widgets: if it was being deleted, but the user was
 hovering it, that element should be removed when the movement stops. As it
 triggers `wpWidgets.save` and we handle dirty states there, I think there
 is no need to check that again. Do you agree?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41894#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list