[wp-trac] [WordPress Trac] #42112: Customize Menus: Adjust "Menu Locations" labels for singular/plural

WordPress Trac noreply at wordpress.org
Tue Oct 10 17:03:00 UTC 2017


#42112: Customize Menus: Adjust "Menu Locations" labels for singular/plural
--------------------------+-----------------------
 Reporter:  melchoyce     |       Owner:  bpayton
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+-----------------------

Comment (by felipeelia):

 Replying to [comment:4 westonruter]:
 > It looks good to me too, but @felipeelia why introduce a new template
 variable for `locationsTitle` when it could just replace the `_e()` call
 with an `echo _n()` in `tmpl-nav-menu-locations-header`?

 Hi @westonruter :)
 I think it couldn't be replaced by `_n` directly because we don't have the
 number of locations avaiable inside `print_templates()` function. Please
 correct me if I'm wrong.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42112#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list