[wp-trac] [WordPress Trac] #42102: File Editor: Make fatal error detection more robust for edits to PHP files

[WordPress Trac]

#42102: File Editor: Make fatal error detection more robust for edits to PHP files
-------------------------------------+--------------------------
 Reporter:  westonruter              |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.9
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:  worksforme
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by pixolin):

 * status:  accepted => closed
 * resolution:   => worksforme


Comment:

 Replying to [comment:4 westonruter]:
 > @pixolin Would you test [attachment:42102.0.diff]?

 Tested the patch: '''works perfectly!'''

 After intentionally adding a syntax error and saving the changes I get an
 error message that my "code changes were rolled back due to an error"
 pointing exactly at the wrong syntax. I can revert the change, save and
 then continue to work. Thank you.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42102#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform