[wp-trac] [WordPress Trac] #42140: Incorrect use of plural in class-wp-customize-themes-section.php
WordPress Trac
noreply at wordpress.org
Sun Oct 8 09:08:23 UTC 2017
#42140: Incorrect use of plural in class-wp-customize-themes-section.php
--------------------------+------------------------------
Reporter: tobifjellner | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: dev-feedback | Focuses:
--------------------------+------------------------------
Changes (by swissspidy):
* keywords: 2nd-opinion dev-feedback => dev-feedback
* component: Themes => Customize
Comment:
Unfortunately `_n()` can't be used as these strings are loaded in a
JavaScript context, not in PHP. See also #42139.
Although the count is initially `0`, it is updated in
`wp.customize.ThemesSection.updateCount()`.
We could add a separate string for when there's exactly 1 theme. Then,
`wp.customize.ThemesSection.updateCount()` would switch strings
accordingly. Or we really use something like `Number of themes: %s` or
`Themes: %s`.
As mentioned in the other ticket, this won't be a problem after something
like #20491 gets into core.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42140#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list