[wp-trac] [WordPress Trac] #42140: Incorrect use of plural in class-wp-customize-themes-section.php

WordPress Trac noreply at wordpress.org
Sun Oct 8 08:27:33 UTC 2017


#42140: Incorrect use of plural in class-wp-customize-themes-section.php
--------------------------------------+------------------------------
 Reporter:  tobifjellner              |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Themes                    |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  2nd-opinion dev-feedback  |     Focuses:
--------------------------------------+------------------------------
Changes (by danieltj):

 * keywords:   => 2nd-opinion dev-feedback


Comment:

 I'm not too sure of the issue here, I could be wrong though.

 After looking at the code in question, the number that is used is hard-
 coded as `0` (zero).

 So irrespective of whether we switch to using `_n()` or not, when loaded
 it will always say `0 themes`.

 If this is correct, I'm tempted to change it to `_x()` instead so we can
 provide additional context about the 0 in this case.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42140#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list