[wp-trac] [WordPress Trac] #42124: Unit test errors with PHPUnit 6.4.0

[WordPress Trac]

#42124: Unit test errors with PHPUnit 6.4.0
-----------------------------------+------------------
 Reporter:  joemcgill              |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  high                   |   Milestone:  4.9
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------

Comment (by johnjamesjacoby):

 This patch seems right.

 `assertNotInternalType()` claims to accept a PHP Resource variable type,
 so the `resource` string would not be sufficient; it would need to be an
 actual resource type variable. If this was working before PHPUnit 6.4.0,
 it probably should not have been.

 WordPress uses Resource variables in quite a few places (where server &
 database connections are used) but also generally shields us from needing
 to do very much with them until we hit API bedrock. @joemcgill you're
 probably familiar with them with your recent trip down MimeType boulevard.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42124#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform