[wp-trac] [WordPress Trac] #31779: Warn users before using a built-in file editor for the first time
WordPress Trac
noreply at wordpress.org
Thu Oct 5 02:39:47 UTC 2017
#31779: Warn users before using a built-in file editor for the first time
-------------------------------------------------+-------------------------
Reporter: helen | Owner: helen
Type: enhancement | Status: reviewing
Priority: high | Milestone: 4.9
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch ui- | Focuses: ui,
feedback needs-refresh | administration
-------------------------------------------------+-------------------------
Comment (by adamsilverstein):
[attachment:31779.3.diff] is a great start, I built on that in
[attachment:31779.4.diff] and added:
* an ajax callback to handle the close action
* a nonce to make the callback secure
* a localized variable set to 'theme' or 'plugin' to save the correct user
metta settings (its separate for each screen)
After these changes, once you dismiss the modal once it doesn't show up
again on that screen. The modal text still needs adjusting, it says plugin
on the theme screen for example. Also, I haven't tested the modal on
mobal/various screen sizes.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31779#comment:72>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list