[wp-trac] [WordPress Trac] #42093: Improve handling of SUBDOMAIN_INSTALL test coverage

WordPress Trac noreply at wordpress.org
Wed Oct 4 18:55:46 UTC 2017


#42093: Improve handling of SUBDOMAIN_INSTALL test coverage
------------------------------+-----------------
 Reporter:  jeremyfelt        |      Owner:
     Type:  task (blessed)    |     Status:  new
 Priority:  normal            |  Milestone:  4.9
Component:  Build/Test Tools  |    Version:
 Severity:  normal            |   Keywords:
  Focuses:  multisite         |
------------------------------+-----------------
 We have a bunch of tests that run (or are skipped) based on
 `is_subdomain_install()`, but our Travis CI configuration never runs the
 tests in a subdomain configuration.

 To run the tests now, you need to setup the environment manually. In its
 current state, 7 tests fail:

 {{{
 1) Tests_Multisite_Site::test_created_site_details
 2) Tests_Multisite_Site::test_new_blog_url_schemes with data set #0
 ('https', 'https', false)
 3) Tests_Multisite_Site::test_new_blog_url_schemes with data set #1
 ('http', 'https', false)
 4) Tests_Multisite_Site::test_new_blog_url_schemes with data set #2
 ('https', 'http', false)
 5) Tests_WP_oEmbed::test_wp_filter_pre_oembed_result_multisite_sub_samesub
 6)
 Tests_WP_oEmbed::test_wp_filter_pre_oembed_result_multisite_sub_othersub
 7)
 Tests_WP_oEmbed::test_wp_filter_pre_oembed_result_multisite_preserves_switched_state
 }}}

 The first is a result of our site factory only creating new subdirectory
 sites. I believe the `test_new_blog_url_schemes` should be skipped for
 `is_subdomain_install()`, but I haven't verified. I'm not sure yet what
 the issue is with the oEmbed tests.

 I'd like to:
 * Clean up the existing tests so that they pass.
 * Determine a good way of running these in our Travis CI configuration.

 It'd be nice *not* to run the entire set of core/multisite tests again
 just to account for this. Hopefully there's a creative approach to run
 only the subdomain specific tests.

 Previously: #36567, #36566.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42093>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list