[wp-trac] [WordPress Trac] #40109: Ensure PHP 7.2 compatibility in tests (and core)

[WordPress Trac]

#40109: Ensure PHP 7.2 compatibility in tests (and core)
------------------------------+------------------
 Reporter:  ocean90           |       Owner:
     Type:  task (blessed)    |      Status:  new
 Priority:  normal            |   Milestone:  4.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+------------------

Comment (by johnbillion):

 In [changeset:"41730"]:
 {{{
 #!CommitTicketReference repository="" revision="41730"
 I18N: Improvements to the tests for plural forms.

 * Move the `create_function()` code into a file that's only loaded, and
 into a test that's only run, on PHP <= 7.2 to avoid deprecated warnings in
 7.2+.
 * Convert the test skipping into a failure if the GlotPress locale file
 cannot be downloaded.
 * Ensure `test_exceptions` fails if an exception is not thrown.
 * Docs improvements

 See #41562, #40109
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40109#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform