[wp-trac] [WordPress Trac] #42049: Customize Themes: extensibility improvements
WordPress Trac
noreply at wordpress.org
Wed Oct 4 06:30:53 UTC 2017
#42049: Customize Themes: extensibility improvements
-------------------------------------+-------------------------------
Reporter: celloexpressions | Owner: celloexpressions
Type: enhancement | Status: reviewing
Priority: normal | Milestone: Future Release
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses:
-------------------------------------+-------------------------------
Changes (by westonruter):
* keywords: has-patch commit => has-patch needs-refresh
* owner: westonruter => celloexpressions
* milestone: 4.9 => Future Release
Comment:
In extensibility, I don't think we should just yet add a bunch to extend
when we haven't yet solidified the foundation. I'd rather make sure we
have the core themes experience in place, and then in a subsequent release
add extensibility. That way we'd be able to ensure that extensions are
building off of a solid base. We can add the extensibility in 4.9.x even,
as part of a v3 of the themes experience.
@celloexpressions also, the patch isn't applying on `trunk` as of r41723
at least (this is before #42083):
{{{
$ grunt patch:42049
Running "patch:42049" (patch) task
(Stripping trailing CRs from patch.)
patching file src/wp-admin/js/customize-controls.js
Hunk #1 succeeded at 1649 with fuzz 1 (offset 56 lines).
Hunk #2 succeeded at 1673 (offset 56 lines).
Hunk #3 succeeded at 1739 (offset 56 lines).
Hunk #4 succeeded at 1754 (offset 56 lines).
Hunk #5 succeeded at 1813 (offset 56 lines).
Hunk #6 succeeded at 1830 (offset 56 lines).
Hunk #7 succeeded at 1842 with fuzz 2 (offset 56 lines).
Hunk #8 succeeded at 1855 (offset 56 lines).
Hunk #9 succeeded at 1873 (offset 56 lines).
Hunk #10 succeeded at 1891 (offset 56 lines).
Hunk #11 succeeded at 1917 (offset 56 lines).
Hunk #12 succeeded at 1968 (offset 56 lines).
Hunk #13 succeeded at 1978 (offset 56 lines).
Hunk #14 succeeded at 1992 (offset 56 lines).
Hunk #15 succeeded at 2010 (offset 56 lines).
Hunk #16 FAILED at 2026.
Hunk #17 succeeded at 2066 (offset 56 lines).
Hunk #18 succeeded at 2096 (offset 56 lines).
Hunk #19 succeeded at 4662 (offset 27 lines).
1 out of 19 hunks FAILED -- saving rejects to file src/wp-admin/js
/customize-controls.js.rej
(Stripping trailing CRs from patch.)
patching file src/wp-includes/class-wp-customize-manager.php
Hunk #1 succeeded at 4275 (offset 71 lines).
Hunk #2 succeeded at 4807 (offset 71 lines).
Hunk #3 succeeded at 4837 (offset 71 lines).
Hunk #4 succeeded at 4845 (offset 71 lines).
Hunk #5 succeeded at 4862 (offset 71 lines).
Hunk #6 succeeded at 4933 (offset 71 lines).
(Stripping trailing CRs from patch.)
patching file src/wp-includes/customize/class-wp-customize-themes-
section.php
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42049#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list