[wp-trac] [WordPress Trac] #30186: Add plugin icons to plugin list table in update-core.php

[WordPress Trac]

#30186: Add plugin icons to plugin list table in update-core.php
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:  pento
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots ui-feedback has-     |     Focuses:  ui,
  patch                                          |  administration
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-screenshots needs-patch ui-feedback => has-screenshots ui-
     feedback has-patch


Comment:

 In [attachment:30186.5.diff]:

 - Remove icons from the plugin list table, only show them on the updates
 screen.
 - Favour the 128x128 icon over the 256x256 icon, if the API returns both.
 - Apply fallback icon styling from @melchoyce.

 Note: The w.org API returns four icons: `default`, `svg`, `2x`, and `1x`.

 `svg`, `2x`, and `1x` are only defined if the plugin has those icons
 uploaded, `default` will be set to the first of `svg`, `2x`, or `1x` that
 is defined.

 So, by using `default` in [41695], `svg` is the preferred icon, but it's
 falling back to `2x`, by virtue of how the w.org API decides preference.
 [attachment:30186.5.diff] explicitly defines the preference order for the
 updates screen plugin list as: `svg`, `1x`, `2x`, then `default`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30186#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform