[wp-trac] [WordPress Trac] #40138: Bundled themes: the tag cloud widget should output a list

[WordPress Trac]

#40138: Bundled themes: the tag cloud widget should output a list
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  enhancement                          |  sami.keijonen
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  tag-cloud has-patch 2nd-opinion      |  Resolution:
  needs-testing                                  |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by davidakennedy):

 Hi @xkon and @sami.keijonen:

 Thanks again for the work here. With some small tweaks, this should be
 ready. After some further testing, here's my feedback.

 One thing to note is each of most of these themes has a "Widgets" section
 of the stylesheet. That would be a good place to put these styles to keep
 things consistent. Also, it's good to test the widget in multiple places.

 Ten

 * Put new styles into widgets section of stylesheet.
 * Add RTL styles. Like:


 {{{
 #main .widget-area .tagcloud ul,
 .widget-area .tagcloud ul {
         margin-right: 0;
 }
 }}}


 Eleven

 * Put new styles into widgets section of stylesheet.

 Twelve

 * Cancel out top margin on li items on front page template footer widget
 area. Like:

 {{{
 .template-front-page .widget-area .widget.widget_tag_cloud li {
         margin: 0;
 }
 }}}

 * Put new styles into widgets section of stylesheet.

 Thirteen

 * Put new styles into widgets section of stylesheet.

 Fourteen

 * Put new styles into widgets section of stylesheet, in list style widgets
 * I don't think the margins on the li items are needed. It makes the tag
 cloud appear too different than the previous design. Without that, no RTL
 styles are needed.

 Fifteen

 * Put new styles into widgets section of stylesheet, in list style widgets
 * I don't think the margins on the li items are needed. It makes the tag
 cloud appear too different than the previous design. Without that, no RTL
 styles are needed.

 Sixteen

 Looks good! A few small tweaks:

 *The comment "/* Tag Cloud UL Style Fixes */" isn't needed because it's
 just additional styles.
 * Add RTL styles. Like:

 {{{
 .tagcloud ul {
         margin-right: 0;
 }
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40138#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform