[wp-trac] [WordPress Trac] #42081: Some widget controls are too wide for their container
WordPress Trac
noreply at wordpress.org
Tue Oct 3 23:31:52 UTC 2017
#42081: Some widget controls are too wide for their container
-----------------------------------+---------------------------------
Reporter: johnbillion | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Widgets | Version: 3.8
Severity: minor | Resolution:
Keywords: has-screenshots close | Focuses: ui, administration
-----------------------------------+---------------------------------
Changes (by westonruter):
* keywords: needs-patch has-screenshots => has-screenshots close
Comment:
@johnbillion This is actually a feature. These are the “wide” widgets in
WordPress. It gets triggered when a widget is defined with a width wider
than 250px. You can see the widgets in how the widgets are defined:
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
includes/widgets/class-wp-widget-custom-html.php#L50
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
includes/widgets/class-wp-widget-rss.php#L29
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
includes/widgets/class-wp-widget-text.php#L39
Letting the Custom HTML widget be wide was actually explicitly implemented
in [41000].
Accommodating them in the admin and Customizer is not pretty but they are
supported:
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
admin/js/customize-widgets.js#L593-L662
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
admin/js/widgets.js#L150-L159
* https://github.com/WordPress/wordpress-develop/blob/43a34c9/src/wp-
includes/class-wp-customize-widgets.php#L544-L578
Here's a plugin to demo it: https://gist.github.com/westonruter/7141599
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42081#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list