[wp-trac] [WordPress Trac] #42072: Add limit 1 to domain_exists

WordPress Trac noreply at wordpress.org
Tue Oct 3 21:39:17 UTC 2017


#42072: Add limit 1 to domain_exists
--------------------------------------+------------------------
 Reporter:  spacedmonkey              |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.9
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  multisite
--------------------------------------+------------------------

Comment (by jeremyfelt):

 In [attachment:42072.4.diff]:

 * Ensure the URL passed to `get_site_by()` is formatted with expected
 slashes.
 * Remove the `www.wordpress.org` site from tests. Site creation was
 failing because `domain_exists()` would return `true` after `get_site_by(
 'url', 'www.wordpress.org/' );` found `wordpress.org`. We don't support
 the co-existence of `www` and non-`www` domains, so it should be okay to
 apply this restriction to `domain_exists()` now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42072#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list