[wp-trac] [WordPress Trac] #40894: Use Webpack instead of Browserify for build process

[WordPress Trac]

#40894: Use Webpack instead of Browserify for build process
------------------------------+------------------------------
 Reporter:  adamsilverstein   |       Owner:  adamsilverstein
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  4.9
Component:  Build/Test Tools  |     Version:  3.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  javascript
------------------------------+------------------------------

Comment (by netweb):

 Webpack is pretty new to me and I've not yet grok'd all the things....
 That said.... Please bare with me why I explain my testing timeline....

 When I tested [attachment:40894.3.diff] and refreshed this to become
 [attachment:40894.4.diff] I tested this by converting the `/build`
 directory to a Git folder ( `git init && git add . && git commit`), I then
 renamed the folder to`/build-git` and ran `grunt release` from the root of
 the repo to recreate the `/build` folder, I then copied the contents of
 `/build` to `/build-git` to compare the differences via `git status`, in
 my testing of this there were no changes so I refreshed the patch and
 uploaded [attachment:40894.4.diff] and added no additional comment apart
 for a "thumbs up" to indicate the patch as it stood worked for me as I saw
 no noticeable changes before and after the patch in the output `/build`
 folder.

 Moving along, [attachment:40894.5.diff] at a cursory glance is quite
 similar to [attachment:40894.4.diff] and [attachment:40894.3.diff] ...

 And then to [attachment:40894.6.diff], this contains significant changes
 to the `src/wp-includes/js/media-audiovideo.js`, `src/wp-includes/js
 /media-grid.js`, `src/wp-includes/js/media-models.js`, and `src/wp-
 includes/js/media-views.js` files, I originally expected these changes in
 the [attachment:40894.3.diff] patch, this is why I performed the testing
 of the [attachment:40894.3.diff] patch the way I did above and I thought
 the reason for why those changes were not in [attachment:40894.3.diff]
 was because I wasn't grok'ing webpack correctly and with no difference
 between before and after applying the patch I thought the changes were
 good enough, maybe perfect enough that the output to the `/build` folder
 had no changes whatsoever and I moved along with nothing worth noting here
 in the comments.

 So, all in all I hadn't grok'd webpack very well and the changes I
 expected are in fact now in [attachment:40894.6.diff] and
 [attachment:40894.7.diff], so for whatever reason this is I'll read and
 re-read and test some more so I do grok what these changes actually are,
 for now though as I'm basically on holidays with family for the next 6
 days I'm unable to test the [attachment:40894.7.diff] patch.

 If others are happy with the state of [attachment:40894.7.diff] then
 commit away, I'll catch up when I get back from holidays but I wanted to
 document the above for my own reference at least... Maybe next week a
 light bulb moment will occur and I'll see what I clearly missed previously
 but don't let me hold this back :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40894#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform