[wp-trac] [WordPress Trac] #21622: Validate or sandbox theme file edits before saving them (as is done for plugins)

[WordPress Trac]

#21622: Validate or sandbox theme file edits before saving them (as is done for
plugins)
-------------------------------------+-----------------------------
 Reporter:  eschwartz93              |       Owner:  westonruter
     Type:  enhancement              |      Status:  accepted
 Priority:  high                     |   Milestone:  4.9
Component:  Themes                   |     Version:  2.7.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+-----------------------------
Changes (by westonruter):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 @Clorith @jdgrimes @jjj @azaozz Here we go!!

 Please test and review these changes: https://github.com/xwp/wordpress-
 develop/pull/272

 * Refactor themes and plugin editors to submit file changes via Ajax
 instead of doing full page refreshes. Moves file modifications from theme-
 editor.php and plugin-editor.php to common Ajax handler.
 * Do sandboxed updates of PHP files for both active themes and plugins,
 with rollbacks in the case of a loopback request results in a fatal error.
 This supersedes changes in #39766 (Plugin does not gracefully fail when
 editing active plugin causes fatal error).

 The improvements to the user experience and the robustness of the file
 editors are huge.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21622#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform