[wp-trac] [WordPress Trac] #40812: Allow wp-login.php page title separator to be filtered
WordPress Trac
noreply at wordpress.org
Mon Oct 2 22:44:31 UTC 2017
#40812: Allow wp-login.php page title separator to be filtered
------------------------------------+-----------------------------
Reporter: henry.wright | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Login and Registration | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------------+-----------------------------
Changes (by SergeyBiryukov):
* keywords: has-patch dev-feedback => needs-patch
Comment:
Replying to [comment:3 SergeyBiryukov]:
> We should either apply the `document_title_separator` filter to the
`$separator` variable, or (preferably) make the login page use
`wp_get_document_title()`, which would solve both this ticket and #40814.
On second thought, both `document_title_separator` and
`wp_get_document_title()` only apply to front-end pages.
I think login page is a part of the admin rather than front-end. Admin
pages use `‹` as a separator, and it's a part of a
[source:tags/4.8.2/src/wp-admin/admin-header.php?marks=50#L28 translatable
string], so that RTL locales could translate it to `›`.
We could use the same approach on login page and apply the `admin_title`
filter there, but that would lead to fatal errors if a plugin calls
`get_current_screen()` on `admin_title`, because it's not available on
login page.
So I guess a new filter, `login_title`, should be introduced.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40812#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list