[wp-trac] [WordPress Trac] #30186: Add plugin icons to plugin list table in update-core.php

WordPress Trac noreply at wordpress.org
Mon Oct 2 15:56:46 UTC 2017


#30186: Add plugin icons to plugin list table in update-core.php
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9
Component:  Upgrade/Install                      |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots shiny-     |     Focuses:  ui,
  updates needs-testing                          |  administration
-------------------------------------------------+-------------------------

Comment (by obenland):

 In `class-wp-plugins-list-table.php`, since variables are not mixed with
 strings anymore, could the `td` attribute style be swapped from single
 quote to the usual double quote?

 Is there a reason you using `esc_attr()` rather than `esc_url()` for the
 icon src?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30186#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list