[wp-trac] [WordPress Trac] #41697: Unused parameter in function is_user_option_local

[WordPress Trac]

#41697: Unused parameter in function is_user_option_local
--------------------------------+---------------------------
 Reporter:  bnap00              |       Owner:  spacedmonkey
     Type:  defect (bug)        |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.9
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  multisite
--------------------------------+---------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch dev-feedback ms-roadmap => needs-patch
 * milestone:  Awaiting Review => 4.9


Comment:

 We should just deprecate `is_user_option_local()` on this ticket without
 making any other changes. It was added in MU (see timeline below) and used
 for a handful of changesets before it the code using it was removed again.
 It never actually did anything with `$user_id` and always deferred to the
 current user.

 * WordPress Admin Bar plugin added to MU trunk -
 https://mu.trac.wordpress.org/changeset/1584
 * Additional code using `is_user_option_local()` added in the 2.7 branch
 of MU - https://mu.trac.wordpress.org/changeset/1735
 * `is_user_option_local()` added to the 2.7 branch of MU -
 https://mu.trac.wordpress.org/changeset/1736
 * WordPress Admin Bar plugin removed from 2.7 branch of MU -
 https://mu.trac.wordpress.org/changeset/1755
 * `is_user_option_local()` added to MU trunk
 https://mu.trac.wordpress.org/changeset/1771
 * The WordPress Admin Bar plugin removed from MU trunk
 https://mu.trac.wordpress.org/changeset/1772

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41697#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform