[wp-trac] [WordPress Trac] #42586: Code Editor: Inconsistent results between finding in CodeMirror vs browder (was: Search function in Editor now broken with update to 4.9)

WordPress Trac noreply at wordpress.org
Tue Nov 28 20:55:14 UTC 2017


#42586: Code Editor: Inconsistent results between finding in CodeMirror vs browder
--------------------------+--------------------------------------------
 Reporter:  wpress2010    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  4.9.2
Component:  General       |     Version:  4.9
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility, administration
--------------------------+--------------------------------------------
Changes (by westonruter):

 * component:  Customize => General


Comment:

 The only thing I can think of doing here is intercept any “Cmd-F” commands
 any route them into CodeMirror. This would mean, however, that a user
 would not be able to do a find to locate a file in the file list, which
 would be unfortunate. Maybe the solution here would be to show a notice
 when doing “Cmd-F” when not focused on CodeMirror to prompt the user to
 focus on CodeMirror to do a find '''of code'''.

 CodeMirror only loads the current viewport into the DOM, so that is why
 the browser's find does not match results as it would in a `textarea`.
 This is for performance.

 Code editor tickets we're keeping in the General component.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42586#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list