[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

WordPress Trac noreply at wordpress.org
Mon Nov 27 01:27:05 UTC 2017


#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  5.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  early commit    |     Focuses:
----------------------------+-----------------------

Comment (by jrf):

 @pento You beat me to it, I was just about to post that the PR has been
 merged ;-)

 There is one more open PR which may or may not be of interest to this
 patch. It's a bug in the same sniff (`DisallowSpaceIndent`) which I
 discovered yesterday. Basically if there are files which start with inline
 HTML and only have the PHP open tag later on, the indentation on the lines
 above the first PHP open tag will not be fixed. This would typically be
 the case in views without File DocBlock header.
 PR in PHPCS: https://github.com/squizlabs/PHP_CodeSniffer/pull/1762

 Just in case this comes into play here, I have updated the
 https://github.com/jrfnl/PHP_CodeSniffer/tree/WP-Core/test-run branch to
 the current PHPCS `master` + PR 1762.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:97>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list