[wp-trac] [WordPress Trac] #39859: wp.media.view.Modal jumps when you open it

[WordPress Trac]

#39859: wp.media.view.Modal jumps when you open it
-----------------------------+----------------------------------------
 Reporter:  andreiglingeanu  |       Owner:  afercia
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  4.9.2
Component:  Media            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  accessibility, javascript
-----------------------------+----------------------------------------
Changes (by afercia):

 * milestone:  Future Release => 4.9.2


Comment:

 @andreiglingeanu right, haven't found an easy way to detect when the modal
 has a title or not. Labeling a modal is very important for accessibility
 and can be done with either `aria-labelledby` targeting a visible element
 or with `aria-label` providing a value. However, it's out of the scope of
 this ticket so let's just fix the scrolling.

 About `freeze`, yes seems it was introduced to fix the scrolling issue,
 see the relevant changeset and ticket:
 https://core.trac.wordpress.org/changeset/23029
 https://core.trac.wordpress.org/ticket/22716

 I still can reproduce the scrolling bug in Firefox when I set `freeze` to
 `false` but avoiding the page to scroll in the first place makes the
 `freeze` workaround serve no purpose. I'd agree to remove it entirely.

 Would you mind testing a bit [attachment:39859.diff] on different browsers
 and in different parts of the admin (edit post, media grid, customizer)?
 Note: changes to the media js files must be applied while running `grunt
 watch` so the built files get automatically updated too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39859#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform