[wp-trac] [WordPress Trac] #42609: Regression: WordPress 4.9 plugin/theme editor cannot edit files when running on a Windows based server

[WordPress Trac]

#42609: Regression: WordPress 4.9 plugin/theme editor cannot edit files when
running on a Windows based server
--------------------------------------------------+--------------------
 Reporter:  Otto42                                |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.9.1
Component:  Editor                                |     Version:  4.9
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch 2nd-opinion good-first-bug  |     Focuses:
--------------------------------------------------+--------------------

Comment (by dd32):

 Replying to [comment:16 Otto42]:
 > @dd32 Windows 10 system, XAMMP, basic default install. Fails by default.
 Nothing special, it's the validate_file call getting a path with a colon
 as the second character.

 I tested with a Windows XP system, XAMMP, basic default install. Works by
 default. Nothing special.

 I understand that it's the `vaildate_file()`, but I'm suggesting that's
 not the bug - the bug is earlier, whatever is causing the full filesystem
 path to be in the POST vars in the first place. They're not supposed to be
 there, and that's what I can't duplicate.

 What's the URL to the plugin editor when you're editing a file, is it
 `plugin-editor.php?file=hello.php&plugin=hello.php`? or does it have the
 full path there? What about in the page source, what's the value of the
 `<input type="hidden" name="file"` fields? What about the header of the
 page? is it `Editing hello.php` or does it have the full path there too?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42609#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform