[wp-trac] [WordPress Trac] #42658: Customize: Heartbeat doesn't refresh changeset lock when branching is enabled
WordPress Trac
noreply at wordpress.org
Wed Nov 22 05:57:16 UTC 2017
#42658: Customize: Heartbeat doesn't refresh changeset lock when branching is
enabled
--------------------------+-----------------------------
Reporter: dlh | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: 4.9
Severity: normal | Keywords: has-patch
Focuses: |
--------------------------+-----------------------------
Heartbeat requests from the Customizer will create a
`WP_Customize_Manager` instance without a `changeset_uuid`. However, when
changeset branching is active and when the manager is instantiated without
a UUID, `WP_Customize_Manager::establish_loaded_changeset()` will generate
a new UUID.
Without the UUID from the client,
`WP_Customize_Manager::check_changeset_lock_with_heartbeat()` won't have a
post ID whose lock should be refreshed.
The attached patch would attempt to address this by including the current
UUID with the heartbeat request. The patch then has
`check_changeset_lock_with_heartbeat()` use the heartbeat UUID to find the
changeset post ID before falling back to
`WP_Customize_Manager::changeset_post_id()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42658>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list