[wp-trac] [WordPress Trac] #41266: Not hard coding the table alias prefix in WP_Meta_Query would make class more extendable
WordPress Trac
noreply at wordpress.org
Wed Nov 22 01:20:40 UTC 2017
#41266: Not hard coding the table alias prefix in WP_Meta_Query would make class
more extendable
-------------------------------------------------+-------------------------
Reporter: thomaslhotta | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting
Component: Query | Review
Severity: normal | Version: 4.8
Keywords: good-first-bug has-patch has-unit- | Resolution:
tests | Focuses:
-------------------------------------------------+-------------------------
Changes (by noisysocks):
* keywords: good-first-bug has-patch needs-unit-tests => good-first-bug
has-patch has-unit-tests
Comment:
Personally, I think Approach 1 is the cleaner solution. `WP_Meta_Query` is
a class and we may as well take advantage of an object oriented approach
to solving this problem.
I've added a unit test to `41266-approach-1.diff` and uploaded it as
`41266.diff`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41266#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list