[wp-trac] [WordPress Trac] #42649: Remove extra space after Dashboard & Comment admin menu

[WordPress Trac]

#42649: Remove extra space after Dashboard & Comment admin menu
----------------------------+---------------------------------
 Reporter:  Hardik Amipara  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Menus           |     Version:  4.9
 Severity:  normal          |  Resolution:
 Keywords:  ui-feedback     |     Focuses:  ui, administration
----------------------------+---------------------------------

Comment (by Hardik Amipara):

 hello @dd32 ,

 if submenu is empty in main menu. then added separator after main menu.


 {{{
 <li class="wp-not-current-submenu wp-menu-separator" aria-
 hidden="true"><div class="separator"></div></li>
 }}}


 wp-admin\css\admin-menu.css


 {{{
 #adminmenu li.wp-menu-separator {
         height: 5px;
         padding: 0;
         margin: 0 0 6px 0;
         cursor: inherit;
 }
 }}}



 {{{
 #adminmenu div.separator {
         height: 2px;
         padding: 0;
 }
 }}}


 wp-admin\menu-header.php

 I & @Shital Patel  we both checked with main menu and submenu.



 {{{
 // hide separators from screen readers
                 if ( $is_separator ) {
                         $aria_hidden = ' aria-hidden="true"';
                 }

                 echo "\n\t<li$class$id$aria_hidden>";

                 if ( $is_separator ) {
                         echo '<div class="separator"></div>';

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42649#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform