[wp-trac] [WordPress Trac] #42573: Templates not working properly

[WordPress Trac]

#42573: Templates not working properly
--------------------------+--------------------
 Reporter:  precies       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.9.1
Component:  Themes        |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------
Changes (by Clorith):

 * keywords:  has-patch => needs-patch


Comment:

 We'll definitely not add any buttons to the UI that will rarely, if ever,
 see use by actual users.

 If we do decide to keep the transient in place, I do like the WP_DEBUG
 check, with it in use there's no need for the extra functions to clear
 things, as the version bump invalidation should take care of things for
 end users, but the patch needs refined a little.

 I looked at [attachment:42573.3.patch] and it just checks if WP_DEBUG is
 true or false, it also needs a check if it's defined altogether.

 On a side note, I agree with adding the transient here, now that we
 recursively scan through the whole theme directory the operation can
 become heavy when we take into account 3rd party premium themes as well
 which are known for bundling plugins and other large code bases making
 them substantially more time consuming than they used to be.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42573#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform