[wp-trac] [WordPress Trac] #42614: Customize: Changesets can still be previewed even after having been published

[WordPress Trac]

#42614: Customize: Changesets can still be previewed even after having been
published
--------------------------+-------------------
 Reporter:  westonruter   |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.9.1
Component:  Customize     |    Version:  4.7
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-------------------
 Steps to reproduce:

 1. Change the site title to “First Changeset”
 2. Save Draft.
 3. Open frontend preview link in a new tab and see “First Changeset” as
 site title.
 4. Back in Customizer tab, publish the changes.
 5. Change the site title now to “Second Changeset”
 6. Publish the changes.
 7. Go back to the frontend preview in the other tab and reload.

 Bug: notice the first changeset is still able to be previewed even though
 it it is published (or rather, trashed, since in core a published
 changeset by default is immediately trashed for garbage collection if
 revisions support is not enabled).

 Note however that if you click the “Customize” link in the admin bar from
 the published changeset frontend preview, you'll land on the Customizer
 with an error (from [https://github.com/WordPress/wordpress-
 develop/blob/b424eecd0b255537ec3b7d87f8096d8158f92aae/src/wp-
 admin/customize.php#L77-L84 customize.php]):

 > This changeset cannot be further modified.

 It seems something similar should be done for changesets on the frontend.
 I can see a case for why being able to preview a changeset with a
 `publish` status could be useful. For example, if revisions are enabled
 for changesets, it could indeed be useful to preview an old published
 changeset to see old changes re-applied. However, when a published
 changeset goes straight to trash, these do not seem they should be able to
 be previewed.

 Should attempting to preview a trashed changeset be silently ignored or
 should there be an error message like when accessing `customize.php` with
 a trashed changeset?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42614>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform