[wp-trac] [WordPress Trac] #42609: Regression: WordPress 4.9 plugin/theme editor cannot edit files when running on a Windows based server

[WordPress Trac]

#42609: Regression: WordPress 4.9 plugin/theme editor cannot edit files when
running on a Windows based server
--------------------------+--------------------
 Reporter:  Otto42        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.9.1
Component:  Editor        |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------

Comment (by Otto42):

 The specific issue is here:

 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L388

 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L448

 The validate_file function will return 2 for Windows paths. The
 validate_file_to_edit ignores this case and returns null, which is not
 ideal. The validate_file_to_edit function seems strangely written and
 probably needs refactoring overall.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42609#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform