[wp-trac] [WordPress Trac] #42574: MediaElement upgrade causing JS errors when certain languages are in use e.g de_DE-formal

[WordPress Trac]

#42574: MediaElement upgrade causing JS errors when certain languages are in use
e.g de_DE-formal
-------------------------------------+-------------------------------------
 Reporter:  erich_k4wp               |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  high                     |   Milestone:  4.9.1
Component:  Media                    |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch 2nd-opinion    |     Focuses:  javascript,
  needs-testing                      |  administration
-------------------------------------+-------------------------------------

Comment (by flixos90):

 I prefer to go with @Clorith's second suggestion as that makes us
 independent of MediaElement.js, and given our formats for those more
 specific language variants are not really any standard (at least to my
 knowledge), we should ensure what we pass to the script is valid.

 I uploaded [attachment:42574.2.diff] as a possible implementation with a
 new function to accomplish this, as the logic is a little more than a one-
 liner. This furthermore makes it reusable, as plugins might enqueue other
 JS dependencies that don't handle those variants, and they could then use
 that function.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42574#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform