[wp-trac] [WordPress Trac] #42574: MediaElement upgrade causing JS errors when certain languages are in use e.g de_DE-formal

[WordPress Trac]

#42574: MediaElement upgrade causing JS errors when certain languages are in use
e.g de_DE-formal
-------------------------------------+-------------------------------------
 Reporter:  erich_k4wp               |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  high                     |   Milestone:  4.9.1
Component:  Media                    |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch 2nd-opinion    |     Focuses:  javascript,
  needs-testing                      |  administration
-------------------------------------+-------------------------------------
Changes (by blobfolio):

 * keywords:   => has-patch 2nd-opinion needs-testing


Comment:

 The attached patch should do the trick. :)

 There are two changes:

  * The `$` has been removed from the problematic regexp mentioned in the
 OP. This allows locales with non-conforming end pieces like "-formal" to
 survive.
  * An extra condition is inserted to truncate such locales ''if'' ME.js
 doesn't have a translation. For example, `de-DE-formal` becomes `de-DE`.

 All remaining locale-handling logic continues as usual after that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42574#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform