[wp-trac] [WordPress Trac] #29205: Remove manual UTC offsets that are not officially used

WordPress Trac noreply at wordpress.org
Thu Nov 9 22:09:54 UTC 2017


#29205: Remove manual UTC offsets that are not officially used
-------------------------+------------------------------
 Reporter:  nerrad       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Date/Time    |     Version:  2.9.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  administration
-------------------------+------------------------------

Comment (by Rarst):

 Replying to [comment:11 ryanduff]:
 > I've gone ahead and created a patch that trims the manual offsets down
 to the valid set. One of the issues I found with people setting invalid
 manual offsets is that if you're doing some DateTime things in PHP and
 passed it an invalid offset to convert to timezone, it throws a fatal
 error. So I'm certainly in the camp of only providing a valid set of
 options.

 Any more details on how you managed fatal? I was able to instance
 DateTimeZone from these "wrong" offsets just now without any issue.

 More generally the main issue with numeric offsets in WP isn't that some
 of them are wrong, but that all of them are broken in how time zones are
 handled in localization. See #34835

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29205#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list