[wp-trac] [WordPress Trac] #42321: Menu title field does not clear invalid class

[WordPress Trac]

#42321: Menu title field does not clear invalid class
--------------------------------------+---------------------------------
 Reporter:  ritukaushal5693           |       Owner:  ashokrd2013
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.9.1
Component:  Menus                     |     Version:  4.8.2
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui, administration
--------------------------------------+---------------------------------
Changes (by welcher):

 * keywords:  good-first-bug has-patch needs-testing => good-first-bug has-
     patch
 * milestone:  Awaiting Review => 4.9.1


Comment:

 I've done a slight refactor on the approach here.

 Now instead of adding the `form-invalid` class to the div that wraps the
 entire form, I've added a new `input.invalid` selector which is
 added/removed to the input directly. This should prevent any unintended
 side effects of changing CSS.

 Also, I have added an inline comment in `scripts-loader.php` that
 references this ticket to explain why we now have underscore as a
 dependency for `nav-menu.js` as that is not consistent across scripts
 loaded in wp-admin.

 I think this is ready to go for 4.9.1

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42321#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform