[wp-trac] [WordPress Trac] #42411: Theme admin screen allows Live Preview while changeset is drafted/scheduled

[WordPress Trac]

#42411: Theme admin screen allows Live Preview while changeset is drafted/scheduled
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  accepted
Component:  Customize                            |   Milestone:  4.9.1
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-patch has-screenshots ux-        |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  has-patch has-screenshots dev-feedback => has-patch has-
     screenshots ux-feedback
 * milestone:  4.9 => 4.9.1


Comment:

 Thinking about this some more, and I think actually that we can revisit
 this later. It turns out that actually if you have drafted changes in the
 Customizer, and then leave to go to the WP Admin's Themes screen… when
 clicking Live Preview from there the Customizer actually won't open up
 with the previously-drafted changeset autoloaded because of this key line
 in `WP_Customize_Manager::establish_loaded_changeset()`:

 {{{#!php
 <?php
 if ( ! $this->branching() && $this->is_theme_active() ) {
 }}}

 So no drafted/scheduled changeset will be autoloaded when previewing a
 theme switch anyway. After switching the theme, you can then exit the
 Customizer and come back in to continue editing the previous changeset.
 Still not ideal, but I think @obenland is right that this needs some more
 thought in terms of UX. (After activating the theme, should a notification
 then appear prompting them to switch to the previously-drafted changeset?)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42411#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform