[wp-trac] [WordPress Trac] #38946: WP_Upgrader: Protection against deleting files in destination directory

[WordPress Trac]

#38946: WP_Upgrader: Protection against deleting files in destination directory
-----------------------------+------------------------------
 Reporter:  shivapoudel      |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------
Changes (by dd32):

 * keywords:  has-patch dev-feedback => has-patch


Comment:

 @shivapoudel Would you be able to upload an example of the scenario, or a
 way to trigger it? Due to the limited experience many committers have with
 the `WP_Upgrader` classes it's not as easy for others to review/weigh in
 on the ticket.

 Despite my earlier comments, I don't think extending the
 `$protected_directories` functionality is something I support.

 The better option, and probably only option I can think of, would be an
 action within the install routines which allows changing some of the args
 which has been passed in, after the package has been extracted, and
 probably at other points of the process.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38946#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform