[wp-trac] [WordPress Trac] #42439: Update random_compat external library for PHP 7 linting failure

WordPress Trac noreply at wordpress.org
Mon Nov 6 00:17:28 UTC 2017


#42439: Update random_compat external library for PHP 7 linting failure
--------------------------------+------------------------------
 Reporter:  jrdelarosa          |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  External Libraries  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:
--------------------------------+------------------------------

Comment (by dd32):

 Diffing the versions in github looks sane, as does this patch.

 It's always been expected that these files would not parse under PHP7, as
 they're not loaded there. Unfortunately it seems that WPEngine blocks
 deploying these files, causing issues.

 While I have no issue updating these, as we're so close to the 4.9
 release, I'm tempted to leave it until 4.9.1 or 5.0 - even though I don't
 expect it'll cause any breakage.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42439#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list