[wp-trac] [WordPress Trac] #39859: wp.media.view.Modal jumps when you open it

[WordPress Trac]

#39859: wp.media.view.Modal jumps when you open it
-----------------------------+----------------------------------------
 Reporter:  andreiglingeanu  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Future Release
Component:  Media            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  accessibility, javascript
-----------------------------+----------------------------------------

Comment (by andreiglingeanu):

 Hey @afercia,

 I'm getting back with a fresh patch on that which fixes that jump by
 swapping the element where the focus is happening on.

 Everything works as expected but I do have two questions:

 1. I'm not really able to easily add the `aria-labelledby` attribute that
 will point to the visible heading in the modal. That's because sometimes,
 this blueprint Backbone View is used as part of other modals, which may or
 may not have a heading. That is, I would need to introduce a conditional
 somehow in the `media-modal` underscore template for deciding whether to
 insert or not that attribute. Is that something that ''really'' needs to
 be done?

 2. I'm getting back to the `_freeze` option for the `wp.media.view.Modal`,
 which I described back in the original description. Is that something I
 should remove as part of resolving that ticket? I feel like that was a
 hack around this wrongly focused element which caused the browser to jump
 back and forth.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39859#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform