[wp-trac] [WordPress Trac] #41870: Code Editor: Add grunt task for building new CodeMirror bundles from external dependencies

WordPress Trac noreply at wordpress.org
Thu Nov 2 21:52:54 UTC 2017


#41870: Code Editor: Add grunt task for building new CodeMirror bundles from
external dependencies
-------------------------------------------+------------------------------
 Reporter:  westonruter                    |       Owner:  adamsilverstein
     Type:  task (blessed)                 |      Status:  assigned
 Priority:  normal                         |   Milestone:  5.0
Component:  Build/Test Tools               |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch early needs-testing  |     Focuses:  javascript
-------------------------------------------+------------------------------

Old description:

> After [41376] for #12423, it would be ideal if the CodeMirror bundling
> logic (via browserify) could be added as part of core. In this way, the
> external dependencies (CodeMirror and the linter linraries) can be
> managed by NPM. For now, just the minified bundles are being included.
>
> The logic used in the Better Code Editing plugin for creating the bundles
> can be seen here: https://github.com/WordPress/better-code-
> editing/pull/92/files
>
> Depends on #40894 which replaces Browserify with Webpack in core.
>
> Additionally, the linters are currently being included as separate
> assets. They are not being minified, other than they are already minified
> as distributed. These could either benefit from additional uglification
> or bundling with codemirror if they are not going to be enqueued
> separately. The same goes for the `htmlhint-kses` script.

New description:

 After [41376] for #12423, it would be ideal if the CodeMirror bundling
 logic (via browserify) could be added as part of core. In this way, the
 external dependencies (CodeMirror and the linter linraries) can be managed
 by NPM. For now, just the minified bundles are being included.

 The logic used in the Better Code Editing plugin for creating the bundles
 can be seen here: https://github.com/WordPress/better-code-
 editing/pull/92/files

 Depends on #40894 which replaces Browserify with Webpack in core.

 See also #42424, where we need to fix line-endings for CSSLint.

 Additionally, the linters are currently being included as separate assets.
 They are not being minified, other than they are already minified as
 distributed. These could either benefit from additional uglification or
 bundling with codemirror if they are not going to be enqueued separately.
 The same goes for the `htmlhint-kses` script.

--

Comment (by westonruter):

 Note: The line endings of CSSLint need to be fixed as part of this. See
 #42424.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41870#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list