[wp-trac] [WordPress Trac] #42411: Theme admin screen allows Live Preview while changeset is drafted/scheduled

[WordPress Trac]

#42411: Theme admin screen allows Live Preview while changeset is drafted/scheduled
--------------------------+--------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+--------------------
Description changed by westonruter:

Old description:

> In the Customizer, once you save a draft or schedule changes, you are not
> able to switch themes. A notice is displayed:
>
> > Sorry, you can’t preview new themes when you have changes scheduled or
> saved as a draft. Please publish your changes, or wait until they publish
> to preview new themes.
>
> The install and preview buttons in the Themes sections are then disabled
> to prevent a user from switching themes while changes are drafted.
> However, if you go to the Themes admin screen the preview buttons are
> still enabled there, resulting in a situation where a user could open the
> Customizer for a theme switch when there are already drafted/scheduled
> changes.
>
> See #42126 for the reasons for why are Customizer theme switches disabled
> when there are drafted/scheduled changes.
>
> Two things I think we can do here:
>
> * Disable the live preview buttons.
> * Short-circuit `customize.php` if attempting to load a non-active theme
> with a drafted/scheduled changeset.

New description:

 In the Customizer, once you save a draft or schedule changes, you are not
 able to switch themes. A notice is displayed:

 > Sorry, you can’t preview new themes when you have changes scheduled or
 saved as a draft. Please publish your changes, or wait until they publish
 to preview new themes.

 The install and preview buttons in the Themes sections are then disabled
 to prevent a user from switching themes while changes are drafted.
 However, if you go to the Themes admin screen the preview buttons are
 still enabled there, resulting in a situation where a user could open the
 Customizer for a theme switch when there are already drafted/scheduled
 changes.

 See #42126 for the reasons for why are Customizer theme switches disabled
 when there are drafted/scheduled changes.

 Two things I think we can do here:

 * Disable the live preview buttons while also showing an admin notice
 informing why the Live Preview buttons are disabled.
 * Short-circuit `customize.php` if attempting to load a non-active theme
 with a drafted/scheduled changeset.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42411#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform