[wp-trac] [WordPress Trac] #40736: Ensure that `get_blog_count()` and `get_user_count()` return an integer
WordPress Trac
noreply at wordpress.org
Tue May 30 16:00:42 UTC 2017
#40736: Ensure that `get_blog_count()` and `get_user_count()` return an integer
--------------------------------+------------------------------
Reporter: flixos90 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Networks and Sites | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion | Focuses: multisite
--------------------------------+------------------------------
Comment (by flixos90):
Thanks for the patch @pmbaldha!
Looks good except for a few minor issues:
* Let's cast the values to integers with `(int)` instead of using the old
`intval()`.
* For version numbers, the `4.8` and `4.8.0` should be replaced with
`4.9.0`, as this change won't make it into 4.8.
* `MU` should not be used in the `@since` annotation for new functions.
* The function `get_blog_count()` should be moved to the `ms-
deprecated.php` file.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40736#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list