[wp-trac] [WordPress Trac] #39686: Upgrade MediaElement to 4.X

[WordPress Trac]

#39686: Upgrade MediaElement to 4.X
--------------------------------+----------------------------------------
 Reporter:  rafa8626            |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  4.8.1
Component:  External Libraries  |     Version:  4.7.1
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  accessibility, javascript
--------------------------------+----------------------------------------
Changes (by westonruter):

 * keywords:  has-patch => needs-patch


Comment:

 @grosbouff @rafa8626 The patch in
 [attachment:mediaElement.js.4.1.0-v4.diff] did not apply cleanly so I
 tried fixing it up as well as make some additional changes needed with the
 introduction of media widgets.

 Note that source files in WP should not be re-minified and submitted as
 part of patches, since the WP build process takes care of that. The
 minified files generated as part of a ME.js build are different and should
 be included.

 There is an error about `mejs.rendererName` not being defined in `wp-
 mediaelement.js`; this prevents all players from loading. Workaround in
 [https://github.com/xwp/wordpress-
 develop/pull/232/commits/868a0c23bf587a5b999e320eacf0e32d5ca94bcb
 868a0c2].

 There is a 404 for `mejs-controls.svg`. Added in [https://github.com/xwp
 /wordpress-
 develop/pull/232/commits/e613b037471493af47ae41c7baae60274646aedb
 e613b03].

 I am noticing a few issues with the patch, perhaps in part to my refresh
 of the patch. The YouTube and Vimeo players are not working very well or
 not at all. I've added some screenshots here: https://github.com/xwp
 /wordpress-develop/pull/232#issuecomment-304347911

 Please review and amend a [https://github.com/xwp/wordpress-
 develop/pull/232 pull request] I opened as opposed to submitting patch
 files. That should make it easier to collaborate and review. You can
 either fork the repo and open a PR into the `trac-39686` branch, or I can
 add you as contributors to that repo to push directly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39686#comment:74>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform