[wp-trac] [WordPress Trac] #19629: return option for media_sideload_image

[WordPress Trac]

#19629: return option for media_sideload_image
----------------------------------------+---------------------------
 Reporter:  slbmeh                      |       Owner:  mikeschroder
     Type:  task (blessed)              |      Status:  reopened
 Priority:  normal                      |   Milestone:  4.8
Component:  Media                       |     Version:  3.3
 Severity:  minor                       |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:
----------------------------------------+---------------------------
Changes (by mikeschroder):

 * keywords:  needs-unit-tests => needs-unit-tests has-patch


Comment:

 A first pass at tests for `media_sideload_image()` in
 [attachment:19629.tests.diff].

 A couple notes:
 - This feels a bit hacky, so if there's a better way to catch some of the
 data, anything can be changed here.
 - It's possible this should live in `tests/phpunit/tests/media.php`
 instead of its own file.

 I'm pretty tired at this point, so going to wait for some feedback and do
 another review on it tomorrow before a commit.

 If I'm not around at the proper time before RC, feel free to either commit
 (whether with changes or not), or punt this ticket if it seems necessary.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/19629#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform