[wp-trac] [WordPress Trac] #39883: Code hooking on `image_downsize` can no longer assume the file is an image

WordPress Trac noreply at wordpress.org
Tue May 23 17:01:17 UTC 2017


#39883: Code hooking on `image_downsize` can no longer assume the file is an image
-----------------------------------+------------------------
 Reporter:  stephdau               |       Owner:  joemcgill
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.8
Component:  Media                  |     Version:  4.7
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------

Comment (by stephdau):

 Replying to [comment:27 mikeschroder]:
 > [edit] Would it need to be more granular than "image", since image
 represents more than one file type? [/edit]

 Probably not if we leave the other one as 'pdf'. It's a shame neither
 match the same part of the mime-type format ('''image'''/jpg vs
 application/'''pdf'''), but going with mime-types will lead to that list
 getting out of hand pretty quick. In that light, I'd leave it as `'image',
 'pdf'`, which is clear and concise. Custom additions would be left to the
 integrator's choice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39883#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list