[wp-trac] [WordPress Trac] #37819: alternative translations are not merged in (was: _load_textdomain_just_in_time() is really not nice with alternative translations)

WordPress Trac noreply at wordpress.org
Tue May 23 11:00:45 UTC 2017

#37819: alternative translations are not merged in
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  I18N          |     Version:  4.6
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |     Focuses:
Changes (by muranyia):

 * keywords:  has-patch has-unit-tests => needs-patch
 * severity:  normal => major


 attachment:37819.2.diff:ticket:37819​ aims to solve the defunct assignment
 AND to reverse the direction of the merging.

 I suggest that the referential assignment in source:tags/4.7.3/src/wp-
 includes/l10n.php#L593​ (which seems to be totally unnecessary) is fixed
 a.s.a.p. as **it effectively prevents load_textdomain() from merging in
 any additional translations**.

 Then the idea of changing the merging logic (the second part of said
 patch) can be evaluated more carefully later.
 (See some more comments at #40392)

Ticket URL: <https://core.trac.wordpress.org/ticket/37819#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list