[wp-trac] [WordPress Trac] #40745: Bundled Themes: Add styles for wysiwyg Text and Media widgets

[WordPress Trac]

#40745: Bundled Themes: Add styles for wysiwyg Text and Media widgets
-----------------------------------------------------+--------------------
 Reporter:  Soean                                    |       Owner:
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  4.8
Component:  Bundled Theme                            |     Version:  trunk
 Severity:  blocker                                  |  Resolution:
 Keywords:  has-patch needs-screenshots ui-feedback  |     Focuses:  ui
-----------------------------------------------------+--------------------
Changes (by celloexpressions):

 * severity:  normal => blocker


Comment:

 After evaluating all eight bundled themes, there are some critical issues
 that need to be fixed. Most notably is list styling - for many themes,
 there are no bullet points, and the way the editor converts things to `ul`
 automatically, this could lead to a lot of frustration and
 confusing/unexpected results. Additionally, I found several other issues
 listed below. The scope of my testing was limited generally to each
 theme's primary widget area.

 I don't have time to test them all with the patch, but it looks like
 [attachment:40745.4.diff] addresses many of the issues. The
 MediaElement.js inconsistencies in Twenty Thirteen and Twenty Fourteen
 still need to be addressed there. Once the issues listed below are
 verified as fixed, someone should do a pass on the general design to make
 other less obvious improvements. Where possible, the original theme
 designers should be consulted.

 Based on the scope of issues, and over half of the bundled themes
 requiring at least some adjustments, there needs to be a dev note on
 make/core to discuss updating themes to support the new widgets, with some
 of the common issues (list styling with bullets, list spacing,
 MediaElements, image spacing, etc.). Time should also be allotted and
 effort made with the Theme Review Team to do outreach to theme authors to
 give them time to evaluate and update their themes.

 '''Summary of definite issues that need to be fixed (based on current
 trunk):'''

 Twenty Ten:
 - No issues

 Twenty Eleven:
 - Image widget with caption padding issues
 - Unordered vs. ordered list alignment issues

 Twenty Twelve:
 - No issues

 Twenty Thirteen:
 - Ordered lists missing ordering
 - Unordered lists missing bullets
 - List spacing is very odd
 - MediaElement.js players are missing custom theme coloring and do not
 match media players in post content

 Twenty Fourteen:
 - Ordered lists missing ordering
 - Unordered lists missing bullets
 - MediaElement.js players are missing custom theme coloring and do not
 match media players in post content
 - MediaElement.js players are missing custom theme-specified icons (via
 Genericons, and associated icon recoloring) and do not match media players
 in post content. Screenshot doesn't show it, but the video player
 interactions are particularly different.

 Twenty Fifteen:
 - Inadequate color contrast in image widget caption (and possibly also in
 text widget - needs accessibility team verification)

 Twenty Sixteen:
 - No issues

 Twenty Seventeen:
 - Unordered lists missing bullets
 - List spacing is very odd
 - List numbers hanging into margin come very close to adjacent content
 area (not visible in this particular screenshot)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40745#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform