[wp-trac] [WordPress Trac] #39665: Customize: nav menu fallbacks don't get edit shortcuts

WordPress Trac noreply at wordpress.org
Sun May 21 04:27:17 UTC 2017


#39665: Customize: nav menu fallbacks don't get edit shortcuts
-------------------------------------+------------------
 Reporter:  celloexpressions         |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.8
Component:  Customize                |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------

Comment (by dlh):

 [attachment:39665.4.diff] refactors the previous patch so that it doesn't
 use a closure.

 One observation about the change to `customize-preview-nav-menus.js`: It
 seems to cause the fallback to potentially display in the preview when it
 wouldn't otherwise. You can see this by previewing Twenty Seventeen after
 applying the patch.

 In Twenty Seventeen, when no menu is assigned to the Top Menu location,
 the fallback doesn't display because `header.php` checks `has_nav_menu()`
 before calling `wp_nav_menu()`. But with the change to the JS `refresh()`
 function, the fallback still displays in the Customizer.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39665#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list